Skip to content

fix: H-scroll positions after restore#38822

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
manuel-delverme:patch-1
Jan 19, 2026
Merged

fix: H-scroll positions after restore#38822
pavelfeldman merged 1 commit intomicrosoft:mainfrom
manuel-delverme:patch-1

Conversation

@manuel-delverme
Copy link
Contributor

@manuel-delverme manuel-delverme commented Jan 17, 2026

Copy-paste error?

assigns element.scrollTop to scrollLeft property. This will cause horizontal scroll positions to be restored incorrectly in snapshot rendering.

@manuel-delverme
fix; H-scroll positions after restore
1c1c5e6 
Copy-paste error: assigns element.scrollTop to scrollLeft property. This will cause horizontal scroll positions to be restored incorrectly in snapshot rendering.

Signed-off-by: Manuel <manuel.delverme@gmail.com>
Skn0tt
Skn0tt approved these changes Jan 19, 2026
View reviewed changes
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems like a copy-paste error: https://github.com/microsoft/playwright/pull/33809/changes#diff-3448de0c4b59dc4cbf5203b6737dc9769601e0e638ce29e05b579ae1bb764ea0R386

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Test results for "MCP"

2 failed
❌ [chrome] › mcp/planner.spec.ts:69 › planner_setup_page seed resolution @mcp-macos-15
❌ [chrome] › mcp/planner.spec.ts:131 › planner_setup_page with dependencies @mcp-macos-15

2828 passed, 121 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Test results for "tests 1"

30 failed
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/agent-expect.spec.ts:223 › expectURL success @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:261 › expectURL with regex @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @firefox-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:223 › expectURL success @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:261 › expectURL with regex @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @webkit-ubuntu-22.04-node20
❌ [playwright-test] › playwright.artifacts.spec.ts:127 › should work with screenshot: on @macos-latest-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:333 › merged › should include screenshot on failure @macos-latest-node20
❌ [playwright-test] › ui-mode-trace.spec.ts:426 › should work behind reverse proxy @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:299 › should update missing snapshots in tsx @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20

6 flaky ⚠️ [chromium-library] › library/browsertype-connect.spec.ts:935 › run-server › socks proxy › should proxy based on the pattern `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:645 › run-server › should record trace with sources `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:688 › should indicate current test status `@macos-latest-node20`

34567 passed, 691 skipped

Merge workflow run.

@pavelfeldman pavelfeldman merged commit e8e4639 into microsoft:main Jan 19, 2026
18 of 32 checks passed
This was referenced Jan 19, 2026
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skn0tt Skn0tt Skn0tt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuel-delverme @Skn0tt @pavelfeldman